hijack.sh: Track dmesg.txt collection#1292
Merged
golowanow merged 2 commits intothesofproject:mainfrom Aug 6, 2025
Merged
Conversation
marc-hb
reviewed
Aug 5, 2025
7fa9c5b to
0224e5f
Compare
marc-hb
approved these changes
Aug 5, 2025
Member
Author
|
SOFCI TEST |
0224e5f to
290da35
Compare
Log dmesg.txt collection done by journalctl, and warn if it is empty. Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
Fix potential issues at hijack.sh identified by shellcheck as SC2086 Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
290da35 to
7aaabf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log dmesg.txt collection and warn if it is empty.
This should be just an additional instrumentation to track when a checkpoint is set, and journalctl is called to collect kernel log messages: do we really have an empty log or is it lost at some point by CI.