ALSABAT:fix bug: updated alsabat mixer settings#1263
Merged
golowanow merged 1 commit intothesofproject:mainfrom Mar 14, 2025
Merged
ALSABAT:fix bug: updated alsabat mixer settings#1263golowanow merged 1 commit intothesofproject:mainfrom
golowanow merged 1 commit intothesofproject:mainfrom
Conversation
…ect to UCM2 file for PTL SDW RT722 Signed-off-by: mohsinkh30 <mohsin.khan@intel.com>
Collaborator
|
Can one of the admins verify this patch?
|
Member
|
@mohsinkh30 i wonder is it expected and the new settings work reliable enough ? |
kv2019i
approved these changes
Mar 14, 2025
Contributor
kv2019i
left a comment
There was a problem hiding this comment.
Code change looks good.
The git commit message is not following common style. The summary line should be with 72 characters and there should be a paragraph explaining the change. Your git user name is also not entirely correct.
Not blocker for sof-test, but please note in future PRs.
Contributor
|
@golowanow It's true the volume is very low: Still better than clipping, so I'm ok to fine-tune later. |
bardliao
approved these changes
Mar 14, 2025
golowanow
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alsa_settings/PTLP_RVP_SDW.sh: Modified alsabat mixer settings with respect to UCM2 file for PTL SDW RT722"