kmod: remove snd_seq_dummy and snd_hrtimer#1253
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Feb 17, 2025
Merged
Conversation
snd_seq_dummy and snd_hrtimer are present while pipewire is enabled. snd_seq depends on snd_seq_dummy and snd_timer depends on snd_hrtimer. Old version of sof_remove.sh didn't include those modules so it failed to remove snd_seq and snd_timer. Signed-off-by: Mateusz Redzynia <mateuszx.redzynia@intel.com>
cgturner1
approved these changes
Feb 14, 2025
marc-hb
reviewed
Feb 14, 2025
Collaborator
marc-hb
left a comment
There was a problem hiding this comment.
I see nothing wrong with the small code change but I don't understand the explanation and commit message.
Are these (new?) kernel modules? So how does it affect Ubuntu 24 only? SOF developers are expected to test new kernel versions on any distribution they use.
Or did you mean something like: "The pulseaudio and/or pipewire version and/or configuration in Ubuntu 24 indirectly loads two additional modules"?
I'm confused sorry.
kv2019i
approved these changes
Feb 17, 2025
Contributor
kv2019i
left a comment
There was a problem hiding this comment.
Seems good.
@marc-hb Newer Pipewire versions load these modules under some conditions. Given these are old modules and user could load these via other means as well (and block sof_remove.sh), I think this is useful addition in any case.
lgirdwood
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snd_seq_dummy and snd_hrtimer are present while pipewire is enabled in ubuntu 24.04.
Those modules prevent snd_seq and snd_timer from unloading and sof_remove.sh fails.
Failed logs from old version, these errors are not present with this commit applied.
lsmod output