Conversation
jsarha
requested review from
anton-intel,
deb-intel,
greg-intel,
intelkevinputnam and
lgirdwood
as code owners
Contributor
Author
|
@lgirdwood here is the sof-docs update you were missing. |
Collaborator
|
@jsarha Two warnings on line 30 and line 33 under Build and Deploy are causing your build to fail. The file on line 33 no longer exists (I removed it in a recent PR). Line 30 has been corrected in one of my recent PRs as well. Please be sure to do whatever necessary updates so we can merge your build. |
…date Added firmware kconfig options for enabling probes and logging backend. Also added notes about the latest updates for sof-probes demuxing tool. Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
The statement about enabling a single probe point for buffer thesofproject#7 was misleading. Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
…ences Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
Contributor
Author
|
Rebased and updated the content according to changes requested to thesofproject/sof#6364 |
lgirdwood
approved these changes
Oct 5, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@deb-intel technical side is fine, pls merge when you are happy
deb-intel
approved these changes
Oct 5, 2022
Collaborator
deb-intel
left a comment
deb-intel
left a comment
There was a problem hiding this comment.
Looks good. I will make a few grammatical edits in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validity of these updates depend on this pull request being accepted:
thesofproject/sof#6364