soundwire: intel_ace2x: release bpt_stream when close it#5706
Merged
bardliao merged 1 commit intothesofproject:topic/sof-devfrom Mar 24, 2026
Merged
soundwire: intel_ace2x: release bpt_stream when close it#5706bardliao merged 1 commit intothesofproject:topic/sof-devfrom
bardliao merged 1 commit intothesofproject:topic/sof-devfrom
Conversation
The BPT stream was allocated in intel_ace2x_bpt_open_stream(), we need to free it in intel_ace2x_bpt_close_stream(). Fixes: 4c1ce9f ("soundwire: intel_ace2x: add BPT send_async/wait callbacks") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory/resource leak in the Intel ACE2.x SoundWire driver by releasing the BPT stream runtime during stream close, matching the allocation done during BPT stream open (per the commit referenced in the Fixes tag).
Changes:
- Release
cdns->bus.bpt_streaminintel_ace2x_bpt_close_stream(). - Clear
cdns->bus.bpt_streamtoNULLafter releasing to avoid stale pointers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simontrimmer
approved these changes
Mar 23, 2026
Collaborator
simontrimmer
left a comment
simontrimmer
left a comment
There was a problem hiding this comment.
Looks good, I like the obvious symmetry
Tested on the PTL unit we've been discussing
plbossart
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BPT stream was allocated in intel_ace2x_bpt_open_stream(), we need to free it in intel_ace2x_bpt_close_stream().
Fixes: 4c1ce9f ("soundwire: intel_ace2x: add BPT send_async/wait callbacks")