ASoC: SOF: topology: Use acpi mach from the machine driver#5665
Open
bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
Open
ASoC: SOF: topology: Use acpi mach from the machine driver#5665bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
The parameters may be changed by the machine driver based on the actual hardware configuration. We need to use the acpi mach from the machine driver. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
ranj063
reviewed
Feb 6, 2026
| @@ -2530,8 +2531,12 @@ int snd_sof_load_topology(struct snd_soc_component *scomp, const char *file) | |||
| */ | |||
| bool no_fallback = strstr(file, "dummy"); | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
We use the SOC_SDW_PCH_DMIC quirk to indicate that the PCH DMIC is used. We will set mach_params->dmic_num = DMIC_DEFAULT_CHANNELS; to the mach_params from dev_get_platdata(card->dev) when the quirk is set. But the mach_params of the sof_sdw_get_tplg_files() function is from sdev->pdata. In other words, the mach_params->dmic_num of sof_pdata->machine remains 0 and it will cause the unsupported number of dmics: 0 issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameters may be changed by the machine driver based on the actual hardware configuration. We need to use the acpi mach from the machine driver.