Open
Conversation
|
I agree on the relevance of this line of code. I had to include it too im my own project. By the way I think you should comply with this repo's coding standards, indentation in particular. |
Author
|
@felixmaier1989, with the indentation, previously there was a mix of 2 and 4 spaces in the file. I've set it all to 4. Was there something I missed? |
|
You are right indeed |
Contributor
|
👍 @felixmaier1989 Want to pull this one in for us all? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a problem today using a custom view that calls \Slim\Slim::getInstance();
There were a few others with the same issue here:
https://disqus.com/home/discussion/there4/unit_testing_slim_php_framework_applications_with_phpunit_26/
It just required adding $app->setName('default'); to LocalWebTestCase.
It looks like this was already added to WebTestCase::getSlimInstance(), but was not in the example code that overrides that.