Fixes #39300 - Fix Redfish identify LED handling#939
Open
spesnova717 wants to merge 1 commit into
Open
Conversation
…_if_match Fix IndicatorLED 'On' -> 'Lit' and use patch_if_match for identify
spesnova717
force-pushed
the
feature/fix-indicator-led-lit
branch
from
7604480 to
2b49949
Compare
spesnova717
added a commit
to FujitsuResearch/smart-proxy
that referenced
this pull request
May 20, 2026
…fallback Prefer LocationIndicatorActive for identify status and identify on/off operations when available, and fall back to IndicatorLED for older or partial Redfish implementations. This keeps compatibility across vendors while aligning identify behavior with newer Redfish systems. Add tests for both LocationIndicatorActive and fallback paths. (this commit is intended to be reviewed on top of theforeman#939)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect
IndicatorLEDvalue and use ETag-aware PATCH for identify LED operations in the Redfish BMC provider.Changes
Bug fix: IndicatorLED value
The Redfish specification (DSP0266_1.23.1.pdf) defines
IndicatorLEDaccepted values asLit,Off, andBlinking.The previous implementation used
'On'inidentifyon, which is not a valid Redfish value and would be rejected by spec-compliant BMCs.This PR changes it to the correct value
'Lit'.Improvement: use
patch_if_matchfor identify operationsidentifyonandidentifyoffpreviously usedsystem.patch(payload: ...), which does not include ETag concurrency control.Other state-changing operations like
bootdevicealready usepatch_if_match.This PR aligns the identify LED operations to also use
patch_if_matchfor consistency and to avoid potential race conditions.