Skip to content

Fix compatibility with django-polymorphic 4.6 (complete) #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djmaze wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

Fix compatibility with django-polymorphic 4.6 (complete) #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions nested_admin/polymorphic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ def get_child_polymorphic_models(model):


def get_polymorphic_related_models(model):
return model()._get_inheritance_relation_fields_and_models().values()
model_cls = model().__class__
subclasses = model_cls.__subclasses__()
return [sub_cls for sub_cls in subclasses if model_cls in sub_cls._meta.parents]


def get_compatible_parents(model):
Expand Down Expand Up @@ -87,11 +89,11 @@ def inline_formset_data(self):
formset_fk_model = ""
parent_models = []
compatible_parents = get_compatible_parents(self.formset.model)
sub_models = self.formset.model()._get_inheritance_relation_fields_and_models()
sub_models = get_polymorphic_related_models(self.formset.model)
data["nestedOptions"].update(
{
"parentModel": get_model_id(formset_fk_model),
"childModels": [get_model_id(m) for m in sub_models.values()],
"childModels": [get_model_id(m) for m in sub_models],
"parentModels": [get_model_id(m) for m in parent_models],
"compatibleParents": {
get_model_id(k): [get_model_id(m) for m in v]
Expand Down