Skip to content

CodingTracker project Finished#273

Open
matejadb wants to merge 8 commits into
the-csharp-academy:mainfrom
matejadb:main
Open

CodingTracker project Finished#273
matejadb wants to merge 8 commits into
the-csharp-academy:mainfrom
matejadb:main

Conversation

@matejadb

Copy link
Copy Markdown

Here's my solution to the CodingTracker project.
From the Challenges I implemented some UnitTests, but filtering and stopwatch aren't implemented due to lack of time.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matejadb Thanks for submitting! It's close but this is blocking the approval:

Image

The project should prevent users from entering an end time that is earlier than the start time. At the moment it's possible to create sessions with negative durations (as shown in the screenshot). Consider validating the relationship between the two dates before calculating and saving the session. This is also one of the recommendations in the project tips.

@matejadb

Copy link
Copy Markdown
Author

@matejadb Thanks for submitting! It's close but this is blocking the approval:
Image

The project should prevent users from entering an end time that is earlier than the start time. At the moment it's possible to create sessions with negative durations (as shown in the screenshot). Consider validating the relationship between the two dates before calculating and saving the session. This is also one of the recommendations in the project tips.

I've implemented a check to see if user entered a date in the past. It should be working as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants