cache: add redis key prefix support#8617
Open
cnaples79 wants to merge 2 commits intothanos-io:mainfrom
Open
Conversation
Signed-off-by: Chase Naples <Cnaples79@gmail.com>
Signed-off-by: Chase Naples <Cnaples79@gmail.com>
GiedriusS
reviewed
Jan 2, 2026
Member
There was a problem hiding this comment.
But it's the intention to share results between instances so that they could re-use the results of computation. If the problem is that the keys&values are taking too much space, certain clusters or subset of services can use a different Redis cluster. Could you please elaborate on what problem you're trying to solve?
(Added a comment on the original issue, let's continue the discussion there).
GiedriusS
reviewed
Jan 19, 2026
| start := time.Now() | ||
| results := make(map[string][]byte, len(keys)) | ||
|
|
||
| prefixedKeys := make([]string, len(keys)) |
Member
There was a problem hiding this comment.
Could we please add two separate paths - with and without a prefix? Otherwise, this very hot path will get 2 extra allocations even if one isn't using a prefix.
Member
|
@cnaples79 ping, just one nit and we can merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
Test Plan
Fixes #8608