Query: Support per endpoint TLS configuration#8594
Query: Support per endpoint TLS configuration#8594Naman-B-Parlecha wants to merge 38 commits intothanos-io:mainfrom
Conversation
Signed-off-by: Naman-B-Parlecha <naman.parlecha@finalroundai.com>
Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
Signed-off-by: Naman-B-Parlecha <naman.parlecha@finalroundai.com>
Signed-off-by: Naman-B-Parlecha <naman.parlecha@finalroundai.com>
Signed-off-by: Naman-B-Parlecha <naman.parlecha@finalroundai.com>
Signed-off-by: Naman-B-Parlecha <naman.parlecha@finalroundai.com>
205dc0a to
fddb1b4
Compare
Signed-off-by: Naman-B-Parlecha <naman.parlecha@finalroundai.com>
Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
|
@MichaHoffmann i have refactored to |
There was a problem hiding this comment.
Thanks for this. While I'm not a proper project member, I hope this initial review is helpful. I'll see if I can also test out the change as this is functionality I happen to need.
I note that there is a test failure from CI below, but it appears to be unrelated to this change.
…port Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
54fd19b to
bf8c193
Compare
|
@ringerc can u signoff your commits for the DCO to pass |
cafe60f to
1536749
Compare
Add flag `--remote-write.client-tls-min-version` to set the minimum gRPC client version in Thanos Receive. While an option `--grpc-client-tls-min-version` exists in the shared config logic, it is only enabled and supported by Thanos Query. For historical reasons, Thanos Receive does not use the seemingly-global configuration for the gRPC client in `cmd/thanos/config.go` (options prefixed `--grpc-client-`); it has its own `--remote-write.client-` options instead. Only Query actually uses the global client options. So the new flag is added alongside the existing Thanos Receive gRPC client flags for consistency. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Add tls_config.min_version in Redis TLS client config, so a specific TLS version can be forced in gRPC requests to Redis. Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
|
@Naman-B-Parlecha Done and pushed the amended commits to https://github.com/ringerc/thanos-patches/tree/NamanParlecha/PerEndpointTLS Sorry I forgot to add the sign-off tag. You can to replace your current tree entirely with mine; I've only changed the sign-offs and added one commit to fix a docs checker complaint. Otherwise, you can
You'll need to |
Signed-off-by: Craig Ringer <craig.ringer@enterprisedb.com>
66a0cd0 to
8b790a6
Compare
Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
|
Updated to 1.26 here #8717 so we can remove lots of boilerplate. |
Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
|
@GiedriusS refactored all changed requested PLAT!! thanks:)) |
GiedriusS
left a comment
There was a problem hiding this comment.
Could we mark --endpoint and other parameters as deprecated in cmd/thanos/query.go in this same PR? In other words, let's only support using files for setting endpoints. In next_version+1 we can remove them entirely.
yes read the slack thread regarding this thanks |
Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
|
This is still waiting. What can we do to progress this to merge? |
|
@Naman-B-Parlecha This now needs rebase. Sorry it's taking so long, I'm trying to encourage this to get through final review. |
Co-authored-by: Copilot <copilot@github.com>
|
The docs and unit test failures are not related to pr |
I m still working on this have some edge case and tests to add. Will update description soon.
Changes
Add per-endpoint and default TLS configuration for the Query component via
endpoint.sd-config.client_configwith TLS settings, server name, and compressiondefault_client_configcan be set in the YAML config to apply TLS settings to all endpoints that don't specify their own--grpc-client-tls-*CLI flags are deprecated (hidden from--help) and will be removed after v0.43.0Precedence order
client_config(highest)default_client_configfrom YAML--grpc-client-tls-*CLI flags (deprecated, lowest)Example config
More documentation
Verification
Added debug logs to check if switching between global and per endpoint configuration works as intended