Skip to content

Downgrade React to version 17 until MUI supports React 18 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BayLadyCoder wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Downgrade React to version 17 until MUI supports React 18 #31

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d7fc0c
Downgrade React to version 17 until MUI supports React 18
BayLadyCoder Oct 30, 2022
35ec760
Remove @mui/styles
BayLadyCoder Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 69 additions & 63 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
"@mui/material": "^5.10.10",
"@mui/styles": "^5.10.10",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
"@testing-library/react": "^12.1.5",
"@testing-library/user-event": "^12.1.5",
"@types/jest": "^27.5.2",
"@types/node": "^16.11.64",
"@types/react": "^18.0.21",
"@types/react-dom": "^18.0.6",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"@types/react": "^17.0.0",
"@types/react-dom": "^17.0.0",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-router-dom": "^6.4.2",
"react-scripts": "5.0.1",
"typescript": "^4.8.4",
Expand Down
21 changes: 7 additions & 14 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,11 @@
import React from "react";
import ReactDOM from "react-dom/client";
import App from "./App";
import reportWebVitals from "./reportWebVitals";
import React from 'react';
import { render } from 'react-dom';
import App from './App';
const root = document.getElementById('root');

const root = ReactDOM.createRoot(
document.getElementById("root") as HTMLElement
);
root.render(
render(
<React.StrictMode>
<App />
</React.StrictMode>
</React.StrictMode>,
Copy link
Copy Markdown
Collaborator

@SomparbT SomparbT Oct 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mui/styles is not compatible with React.StrictMode

Copy link
Copy Markdown
Member Author

@BayLadyCoder BayLadyCoder Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed @mui/styles since it's deprecated. We can use sx property instead of @mui/styles, so we can keep the strict mode.

root
);

// If you want to start measuring performance in your app, pass a function
// to log results (for example: reportWebVitals(console.log))
// or send to an analytics endpoint. Learn more: https://bit.ly/CRA-vitals
reportWebVitals();