Fix broken OpenSSL version check for IPv6 proxy in check_proxy() (#3095) [3.2]#3101
Merged
drwetter merged 1 commit intoJul 15, 2026
Merged
Conversation
…tssl#3095) check_proxy() gated IPv6 proxy support on a home-grown version check ${OSSL_VER_MAJOR$}${OSSL_VER_MINOR} -ge 11 at two places, which had a stray "$" causing a "bad substitution" error. On non-LibreSSL builds this aborted the rest of check_proxy() for any IPv6 proxy (literal [addr]:port, or a hostname resolving only to AAAA), so PROXY was never rebuilt into a valid "-proxy ..." argument and downstream openssl calls failed with an error mentioning neither IPv6 nor the proxy. Beyond the typo, the concatenation approach was itself unsound: OSSL_VER_MINOR carries the patch component (e.g. "1.1" for OpenSSL 1.1.1), so ${OSSL_VER_MAJOR}${OSSL_VER_MINOR} yields "11.1" and [[ 11.1 -ge 11 ]] is an arithmetic error. Replace both checks with the dotted-glob idiom used everywhere else in the file for OpenSSL >= 1.1 gates (e.g. testssl.sh:21441, :8216), which is robust and greppable.
This was referenced Jul 15, 2026
Collaborator
|
thanks, @ericcgu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3096 to the 3.2 branch. Fixes #3095.
What is your pull request about?
The same
bad substitutionbug fixed in #3096 (merged to 3.3dev) is present in 3.2 attestssl.sh:22355andtestssl.sh:22368.check_proxy()gated IPv6 proxy support on${OSSL_VER_MAJOR$}${OSSL_VER_MINOR} -ge 11, where the stray$caused abad substitutionerror. On non-LibreSSL builds this aborted the rest ofcheck_proxy()for any IPv6 proxy (literal[addr]:port, or a hostname resolving only to AAAA), soPROXYwas never rebuilt into a valid-proxy ...argument and downstream openssl calls failed with an error mentioning neither IPv6 nor the proxy.Both checks are replaced with the dotted-glob idiom already used elsewhere in this branch for OpenSSL >= 1.1 gates (e.g.
testssl.sh:20860,testssl.sh:2140), which is robust and greppable.If it's a code change please check the boxes which are applicable
help()AI section
Claude Opus 4.8Claude CodeClaude Opus 4.8