Skip to content

bugfix: aesgcm_used --> enc_aesgcm_used#3086

Open
ericcgu wants to merge 1 commit into
testssl:3.3devfrom
ericcgu:ericcgu-bugfix
Open

bugfix: aesgcm_used --> enc_aesgcm_used#3086
ericcgu wants to merge 1 commit into
testssl:3.3devfrom
ericcgu:ericcgu-bugfix

Conversation

@ericcgu

@ericcgu ericcgu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fix Variable Typo #3085

What is your pull request about?

  • [X ] Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change: bug fix, feature or improvement that would cause existing output (especially JSON, CSV) to not work as expected before
  • Typo / spelling fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md
  • My code follows Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

AI section

  • My contribution does not include any AI-generated content
  • [ X ] My contribution includes AI-generated content, as disclosed below:
    • AI Tools: Anthropic Claude Opus 4.8

@drwetter

drwetter commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

@dcooper16 : ok?

@dcooper16

dcooper16 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

@dcooper16 : ok?

It seems ok to me.

The code being fixed in this PR was added by #2796. I don't understand the reason that $enc_chacha_used and $enc_aesgcm_used were defined. As the code is written (once corrected by this PR), $enc_chacha_used or $enc_aesgcm_used will always be true if $plaintext is not empty. So, it seems unnecessary to set one of these variables, and then check its value in addition to checking if $plaintext is not empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants