Skip to content

fix #572: TestNG view may miss results #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
missedone merged 1 commit into from
Mar 7, 2025
Merged

fix #572: TestNG view may miss results #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions testng-eclipse-plugin/src/main/org/testng/eclipse/ui/TestRunnerViewPart.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.concurrent.BlockingQueue;
import java.util.concurrent.LinkedBlockingDeque;

import org.eclipse.core.commands.AbstractHandler;
import org.eclipse.core.commands.ExecutionEvent;
Expand Down Expand Up @@ -209,6 +211,30 @@ public class TestRunnerViewPart extends ViewPart
// MAX_TEXT_SIZE_THRESHOLD.
private static final int MAX_RESULTS_THRESHOLD = 1000;
private static final int MAX_TEXT_SIZE_THRESHOLD = 3;

private static final BlockingQueue<Runnable> SYNC_RUNNABLE_QUEUE = new LinkedBlockingDeque<>();

static {
Thread t = new Thread() {
@Override
public void run() {
while (true) {
try {
Runnable runnable = SYNC_RUNNABLE_QUEUE.take();
runnable.run();
} catch (InterruptedException ex) {
TestNGPlugin.log(ex);
break;
} catch (RuntimeException ex) {
TestNGPlugin.log(ex);
}
}
}
};
t.setName("testng-sync-runnable-executor"); //$NON-NLS-1$
t.setDaemon(true);
t.start();
}

/** Infos for the current suite run. */
private SuiteRunInfo currentSuiteRunInfo;
Expand Down Expand Up @@ -584,9 +610,11 @@ public synchronized void dispose() {
}

private void postSyncRunnable(Runnable r) {
if(!isDisposed()) {
getDisplay().syncExec(r);
}
SYNC_RUNNABLE_QUEUE.add(() -> {
if(!isDisposed()) {
getDisplay().syncExec(r);
}
});
}

private void postAsyncRunnable(Runnable r) {
Expand Down