Migrate TestingBotTestEmbed to Jakarta (StaplerRequest2); fix stale-render bug

[jochen-testingbot]

Completes the Jakarta migration — TestingBotTestEmbed.doIndex was the last javax.servlet/StaplerRequest usage. Migrated to StaplerRequest2/StaplerResponse2/jakarta.servlet.ServletException.

Also fixes review finding #8 (shared-mutable-field): the matched session was stored in a shared field and never reset, so a later unmatched request re-rendered the previous session's media. Now resolved into a local + reset per request.

mvn clean verify green (21 tests, SpotBugs 0); no javax.servlet references remain in src. The embed view render should be confirmed manually against a build with real TestingBot session data.

Note: the larger base-class modernizations (BuildWrapper→SimpleBuildWrapper, RunListener<AbstractBuild>) are deferred — they're L-effort and structurally entangled with why a separate TestingBotTunnelStep exists.

Summary by CodeRabbit

• Bug Fixes
  • Ensured the test result page consistently uses the first matching session for each request.
  • Prevented previously selected build information from carrying over between requests.
  • Updated the embedded page rendering to use the per-request selected build details (test name, links, and iframe source).
• Compatibility
  • Updated request handling to the newer web framework interfaces and servlet exception types.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: df97aaa1-98ec-4fc2-b42f-b90b6adb9007

📥 Commits

Reviewing files that changed from the base of the PR and between 1fd83d6 and 0a78b17.

📒 Files selected for processing (1)

• src/main/java/testingbot/TestingBotBuildObject.java

---

📝 Walkthrough

Walkthrough

TestingBotTestEmbed now uses Stapler 2 and Jakarta Servlet APIs. Its request handler selects the first matching build object per request, stores it in request attributes, and forwards either the result or default Jelly view. The Jelly view reads this request-scoped object.

Changes

TestingBot test embedding

Layer / File(s)	Summary
Update request handler and view selection src/main/java/testingbot/TestingBotTestEmbed.java	Replaces Stapler 1 and javax.servlet types, removes logging and instance-scoped selection, selects the first matching session object, stores it on the request, and forwards the appropriate view.
Pass selected data to the rendered view src/main/java/testingbot/TestingBotBuildObject.java, src/main/resources/testingbot/TestingBotTestEmbed/show.jelly	Derives environmentName from constructor input without retaining the test object, and updates the Jelly view to read test details and embed URLs from the request-scoped object.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant TestingBotTestEmbed
  participant StaplerRequest2
  participant show_jelly
  Client->>TestingBotTestEmbed: request sessionId
  TestingBotTestEmbed->>TestingBotTestEmbed: select first matching build object
  TestingBotTestEmbed->>StaplerRequest2: set request attribute tbo
  TestingBotTestEmbed->>show_jelly: forward selected view
  show_jelly->>StaplerRequest2: read attribute tbo

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately captures the Jakarta/StaplerRequest2 migration and the stale-render fix in TestingBotTestEmbed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch l3-jakarta

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main/java/testingbot/TestingBotTestEmbed.java`:
- Around line 55-66: Remove the shared-state assignment to this.tbo in the
request handling flow, and pass the locally selected TestingBotBuildObject
directly through a request-scoped view model or equivalent mechanism used by
show.jelly. Ensure concurrent requests cannot overwrite each other’s selected
session media or authHash, while preserving index.jelly for unmatched sessions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a06faee0-bf3f-4ab8-97ca-c731f2b190ef

📥 Commits

Reviewing files that changed from the base of the PR and between 8477738 and 51c7659.

📒 Files selected for processing (1)

• src/main/java/testingbot/TestingBotTestEmbed.java