docs: disallow missing docs on crate level and allow where necessary#222
Merged
DDtKey merged 7 commits intotestcontainers:mainfrom Sep 26, 2024
Merged
docs: disallow missing docs on crate level and allow where necessary#222DDtKey merged 7 commits intotestcontainers:mainfrom
DDtKey merged 7 commits intotestcontainers:mainfrom
Conversation
Contributor
Author
|
Okay, lint-reasons were only stabilised in 1.81 (not 1.75) Will switch to comments |
DDtKey
approved these changes
Sep 26, 2024
Contributor
DDtKey
left a comment
DDtKey
left a comment
There was a problem hiding this comment.
Thank you! ❤️
I find this reasonable - we can cover step by step removing allows. But we must enforce it for new changes
DDtKey
changed the title
allow(missing_docs) where nessesary
Merged
DDtKey
pushed a commit
that referenced
this pull request
Sep 26, 2024
## 🤖 New release * `testcontainers-modules`: 0.11.0 -> 0.11.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.11.1] - 2024-09-26 ### Documentation - Disallow missing docs on crate level and allow where necessary ([#222](#222)) ### Features - Implement `with_init_sql` for `Postgres`, `Mysql` and `Mariadb` ([#182](#182)) - Tls certs and ldif file ([#217](#217)) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is more for discussion which of these two approches you would like to prefer:
the advantage of denying now is that regressions (new modules being added without docs) is not possible anymore.
For example, 98429e4 would have been caught in #218 ^^