Skip to content

Conversation

@SubhadityaMukherjee
Copy link
Contributor

Hey,

Just a small change in adding the ability to pass in a custom wait strategy message for MySQL. The current implementation had '.: ready for connections.: ready for connections.*' as a default regex with no option to change it. This PR moves it into a parameter.
No new functionality has been added so I presume the tests can stay the same.

If you find this useful, I can also go over the other implementations and make a similar change wherever this is a problem.

@SubhadityaMukherjee
Copy link
Contributor Author

Okay I did a grep and added similar changes in Cassandra, Kafka and trino where it seemed to also need this as input. As before, I didnt change any functionality so I left the tests unchanged.

Thanks :)

I needed to use testcontainers for a project and tried to debug this for a few hours before getting frustrated and just trying to patch the module instead.

@SubhadityaMukherjee SubhadityaMukherjee changed the title Allow passing in a custom wait strategy string in MySQL Allow passing in a custom wait strategy string in MySQL, Cassandra, Kafka and Trino Jan 19, 2026
@alexanderankin alexanderankin changed the title Allow passing in a custom wait strategy string in MySQL, Cassandra, Kafka and Trino feat: Allow passing in a custom wait strategy string in MySQL, Cassandra, Kafka and Trino Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.05%. Comparing base (d7953b8) to head (569820e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   78.30%   78.05%   -0.25%     
==========================================
  Files          14       14              
  Lines        1212     1212              
  Branches      141      141              
==========================================
- Hits          949      946       -3     
- Misses        222      226       +4     
+ Partials       41       40       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderankin alexanderankin changed the title feat: Allow passing in a custom wait strategy string in MySQL, Cassandra, Kafka and Trino fix: Allow passing in a custom wait strategy string in MySQL, Cassandra, Kafka and Trino Jan 19, 2026
@alexanderankin alexanderankin merged commit be4d09e into testcontainers:main Jan 19, 2026
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants