Use configured health checks as the default wait strategy#1096
Use configured health checks as the default wait strategy#1096digital88 wants to merge 14 commits into
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I fixed some invalid WaitStrategy references in kafka and red panda. Tests pass locally |
|
@cristianrgreco |
Hey @digital88, apologies for the delay, been super busy with work lately! I still need to review this PR, but yes you're right it'll eventually get queued for a major release. |
|
I've had another look at this PR (need to release a major version for dropping node 20, and wanted to add this as part of the release) and found the following issues:
@digital88 WDYT? I notice this PR hasn't gained much traction so not sure how important it is to include. I appreciate that this PR is old (my fault) but if we can fix it up we can probably include it. I'll give it a go. |
|
@digital88 LMK if you want to review the changes, if not I reckon we're good to merge. |
Closes #687
Had to augment ImageInspectInfo & ContainerInspectInfo because dockerode types do not expose HealthCheck nested property in Config property. I opened PR here but not sure when it will be accepted.