Skip to content

test: cover HttpWaitStrategy response predicate retries #11976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjj-n wants to merge 1 commit into
base: main
Choose a base branch
from
+54 −0
Open

test: cover HttpWaitStrategy response predicate retries #11976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions core/src/test/java/org/testcontainers/junit/wait/strategy/HttpWaitStrategyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,29 @@
package org.testcontainers.junit.wait.strategy;

import com.github.dockerjava.api.command.InspectContainerResponse;
import com.sun.net.httpserver.HttpServer;
import org.assertj.core.api.Assertions;
import org.jetbrains.annotations.NotNull;
import org.junit.jupiter.api.Test;
import org.rnorth.ducttape.RetryCountExceededException;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.containers.wait.strategy.HttpWaitStrategy;
import org.testcontainers.containers.wait.strategy.WaitStrategyTarget;
import org.testcontainers.images.builder.ImageFromDockerfile;

import java.io.OutputStream;
import java.net.InetSocketAddress;
import java.nio.charset.StandardCharsets;
import java.time.Duration;
import java.util.Collections;
import java.util.HashMap;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.function.Predicate;

import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

/**
* Tests for {@link HttpWaitStrategy}.
Expand Down Expand Up @@ -181,6 +191,50 @@ void testWaitUntilReadyWithTimeoutAndBadResponseBody() {
waitUntilReadyAndTimeout(createShellCommand("200 OK", "Bad Response"));
}

/**
* Ensures that a response predicate is evaluated again when the first response does not match.
* Test case for: https://github.com/testcontainers/testcontainers-java/issues/2516
*/
@Test
void testWaitUntilReadyWithResponsePredicateRetries() throws Exception {
AtomicInteger requestCount = new AtomicInteger();
HttpServer server = HttpServer.create(new InetSocketAddress("127.0.0.1", 0), 0);
server.createContext(
"/",
exchange -> {
String responseBody = requestCount.getAndIncrement() == 0 ? "not-ready" : "ready";
byte[] response = responseBody.getBytes(StandardCharsets.UTF_8);
exchange.sendResponseHeaders(200, response.length);
try (OutputStream outputStream = exchange.getResponseBody()) {
outputStream.write(response);
}
}
);
server.start();

try {
int exposedPort = 8080;
int mappedPort = server.getAddress().getPort();
InspectContainerResponse containerInfo = mock(InspectContainerResponse.class);
WaitStrategyTarget target = mock(WaitStrategyTarget.class);
when(containerInfo.getName()).thenReturn("http-wait-strategy-test");
when(target.getContainerInfo()).thenReturn(containerInfo);
when(target.getHost()).thenReturn("127.0.0.1");
when(target.getExposedPorts()).thenReturn(Collections.singletonList(exposedPort));
when(target.getMappedPort(exposedPort)).thenReturn(mappedPort);

new HttpWaitStrategy()
.forPort(exposedPort)
.forResponsePredicate("ready"::equals)
.withStartupTimeout(Duration.ofSeconds(5))
.waitUntilReady(target);

assertThat(requestCount).hasValue(2);
} finally {
server.stop(0);
}
}

/**
* Expects the WaitStrategy probing the right port.
*/
Expand Down