Skip to content

chore(scripts/update-checksum): make sure $repo always has a value#27466

Merged
TomJo2000 merged 1 commit intotermux:masterfrom
TomJo2000:fix-update-checksum-repo-detection
Jan 18, 2026
Merged

chore(scripts/update-checksum): make sure $repo always has a value#27466
TomJo2000 merged 1 commit intotermux:masterfrom
TomJo2000:fix-update-checksum-repo-detection

Conversation

@TomJo2000
Copy link
Copy Markdown
Member

I may need to split this out into multiple commits.

package=$(basename ${package})
# Did we get the package in the form of ${channel}/${package_dir}?
if [[ -d "${package_dir}" && -f "${package_dir}/build.sh" ]]; then
repo="${package_dir%\/*}"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main fix of the PR.
If the package got passed as <channel>/<package_name>, get the $repo value from it like we do in the case where we need to do the channel lookup.

@TomJo2000 TomJo2000 force-pushed the fix-update-checksum-repo-detection branch from 19a06b7 to 26b9d7c Compare November 29, 2025 21:51
@TomJo2000
Copy link
Copy Markdown
Member Author

This PR is temporarily paused pending a request from @Biswa96 to make update-checksum agnostic to the $PWD where it is invoked from.
e.g.

# Example 1
cd packages/tmux
$TERMUX_SCRIPT_DIR/scripts/bin/update-checksum
# Updates checksum for tmux

# Example 2
cd packages/vim
$TERMUX_SCRIPT_DIR/scripts/bin/update-checksum . ../../x11-packages/vim-gtk
# Updates checksum for vim and vim-gtk

If that does not cover the usecase(s) you had in mind, please let me know.

@TomJo2000 TomJo2000 marked this pull request as draft December 6, 2025 12:34
@TomJo2000 TomJo2000 marked this pull request as ready for review January 18, 2026 18:25
@TomJo2000 TomJo2000 merged commit 4eea2f0 into termux:master Jan 18, 2026
2 checks passed
@TomJo2000 TomJo2000 deleted the fix-update-checksum-repo-detection branch January 18, 2026 18:26
@TomJo2000 TomJo2000 mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant