chore: Migrate gsutil usage to gcloud storage#7063
Conversation
|
Hi @rileyajones, Can we get your review on this PR? Thanks! |
|
|
||
| #[derive(Clap, Debug)] | ||
| #[clap(name = "gsutil")] | ||
| #[clap(name = "gcloud storage")] |
There was a problem hiding this comment.
I'm not really familiar with this code and the clap library (or Rust, for that matter), but from what I can gather, this might not really be doing anything... I think this is just a testing util (see line 16), and this might be just a display name.
If it's not just a display name, then it probably refers to the testing CLI defined here, which would likely need to keep this name.
AFAICT, the actual interactions with cloud is done via the client here, via http requests.
There was a problem hiding this comment.
as gsutil is deprecated tool and gcloud storage should be used, by this replacement the users can start using gcloud storage instead of gsutil
please let us know if this direct replacement works or not
There was a problem hiding this comment.
Ok.
I think this util is not actually using or interacting with the cli util, but (AFAICT) this name change shouldn't affect anywya, so we can merge this change.
| Test datasets are stored on Google Cloud Storage in the world-readable | ||
| `gs://tensorboard-bench-logs` bucket, whose [bucket README] is online. To run | ||
| against this data, use `gsutil` to copy it to your local machine. | ||
| against this data, use `gcloud storage` to copy it to your local machine. |
There was a problem hiding this comment.
This seems to refer to the actual CLI command provided by google (assuming there is one, and that's why this is change was created), so this change is fine to keep.
There was a problem hiding this comment.
yes gcloud storage is the latest tool instead of gsutil, yes we have this tool
|
I don't know why the CI workflows are not running, and I don't know how to trigger them. It seems doing a force push might do it, so you can try that. |
…6484980fb8aab56f758cd
seems you need to approve the workflows here ?https://github.com/tensorflow/tensorboard/actions/runs/24173181924 |
all the checks are green, please verify and help merge the PR |
3 participants
Automated: Migrate {target_path} from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
gcs-cli-hyd@google.comWe appreciate your partnership in this important migration effort!
#gsutil-migration