Update format of tutorial notebooks#1040
Open
mhucka wants to merge 1 commit intotensorflow:masterfrom
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Code Review
This pull request updates several tutorial notebooks to ensure the TF_USE_LEGACY_KERAS environment variable is set before importing TensorFlow or TensorFlow Quantum. Additionally, it includes minor formatting changes to the reinforcement learning tutorial. A review comment suggests improving the readability of the progress logs in the reinforcement learning notebook by rounding the average reward values to two decimal places.
scripts/format_all.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
scripts/format_all.shproduces some small differences in the tutorials. I further adjusted the results from whatformat_all.shproduced in order to move a comment that ended up in a less-than-ideal place. The result passesscripts/format_all.shwithout further changes.The fact that this difference arose is most likely a sign that I didn't run
scripts/format_all.shduring the final steps of the last release. I will add a note to the release procedure to remind us to do that in the future.