Add clang-format version 18 to requirements.in#1039
Open
mhucka wants to merge 3 commits intotensorflow:masterfrom
Open
Add clang-format version 18 to requirements.in#1039mhucka wants to merge 3 commits intotensorflow:masterfrom
requirements.in#1039mhucka wants to merge 3 commits intotensorflow:masterfrom
Conversation
Higher versions of `clang-format` produce different formatting results.
This is the output of running `./scripts/generate_requirements.sh`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds clang-format to the project's dependency list. The review feedback suggests pinning clang-format to a specific version in requirements.in, rather than using a version range, to ensure consistent code formatting across different environments and prevent potential CI failures caused by minor version updates.
Gemini Code Assist suggestions it's better to avoid a broad range of versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Higher versions of
clang-formatproduce different outputs than the version used to format what's currently in the repository. On a system where the developer installs a system package for clang-format (using, e.g.,apt install clang-format), they may unknowingly get a different version than what was used to format the code in the repository. If they run./scripts/format_all.shthey may see many changes and not realize that it's due to a different in clang-format versions.Adding clang-format to
requirements.inand regeneratingrequirements.txtis an easy way to get a known version of clang-format. Thankfully, requiring clang-format does not bring in other dependencies, so this ends up being a fairly surgical intervention.