fix: await whoami output in compat login --no-browser path - #98
Open
memosr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
handleCompatCommandpasses the result ofcurrentWhoamiOutput()straight intoprintCompatOutputwithout awaiting it.currentWhoamiOutputisasync, so aPromisereachesJSON.stringify, which serialises it as{}.Running
tempo wallet login --no-browserwith an already-configured wallet prints{}instead of the wallet, balance and key payload. Anything scripting against that output gets an empty object.Why it slipped through
printCompatOutput(value: unknown, ...)accepts the promise without a type error.no-floating-promisesdoes not flag it.listSessions,runFundingFlow) are awaited correctly, so only this branch is affected.Fix
Adds the missing
await.Test
test/compat.test.tsasserts the printed payload parses and containswallet,balanceandkey.Verified it actually catches the regression: with the
awaitremoved the assertion fails withexpected undefined to be '0xabfb663c...', because the serialised promise is{}.pnpm test(147 passed),pnpm typecheck,pnpm test:types,pnpm changelog:validate,pnpm check:formatandpnpm check:lintare all green.