fix: OG cleanup, font loading, icon fallbacks, 404 ASCII art#447
Open
fix: OG cleanup, font loading, icon fallbacks, 404 ASCII art#447
Conversation
More specific naming: 'imageDescription' clarifies this field controls the text rendered inside OG images, distinct from 'description' which Vocs uses for HTML meta tags.
Increase line-height from 1.15 to 1.8 and bump minimum font size from 2.5px to 3px to prevent the ASCII art from being squashed on small screens.
In SSR/dynamic rendering mode, the Node.js server handles all requests before Vercel's rewrite layer fires. Since VTCDuBois font files are gitignored and not in the deployment, the server returns 404 before the rewrite to Blob can kick in. Fix by pointing @font-face src and preload links directly to the Blob URL. Remove the now-unnecessary vercel.json rewrite.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Remove all 77 static SVG icons from public/icons/. The icon API now resolves icons exclusively from Vercel Blob (synced from logo.dev), with a live logo.dev fallback using provider.url domain, and a generated letter SVG as the last resort. This eliminates stale local overrides that were blocking fresh Blob-hosted logos from being served.
Single source of truth for logo.dev URL construction, used by both the icon API endpoint and the sync-logos build script.
Single ServiceLogo component replaces three separate inline icon implementations across ServicesPage and ServiceDiscovery. Handles img loading, error fallback to initials, and domain passthrough for logo.dev in one place.
Re-add light background detection and invert filter for icons that need color correction based on the current theme. ServiceLogo now fetches the icon manifest internally and applies filter: invert(1) when an icon has a light background and the user is in dark mode (or vice versa).
The require('node:zlib') call inside decodePngPixels silently failed
in ESM mode, causing all PNG transparency and lightBg detection to
return false. Now correctly detects 11 transparent and 27 light-bg
icons.
brendanjryan
added a commit
that referenced
this pull request
Mar 24, 2026
In SSR/dynamic rendering mode, the Node.js server handles all requests before Vercel's rewrite layer fires. Since VTCDuBois font files are gitignored and not in the deployment, the server returns 404 before the rewrite to Blob can kick in. Fix by pointing @font-face src and preload links directly to the Blob URL. Remove the now-unnecessary vercel.json rewrite. Split from #447.
This was referenced Mar 24, 2026
Collaborator
|
I split 1,2,4 into seperate prs and merged independantly. While some icons look great, others look funny in light mode. We should rebase this pr and isolate the icon change 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Rename
ogDescriptiontoimageDescriptionfrontmatter fieldMore specific naming:
imageDescriptionclarifies this field controls the text rendered inside OG images, distinct fromdescriptionwhich Vocs uses for HTML meta tags.scripts/generate-og-descriptions.ts: updated regexsrc/pages/_api/api/og.tsx: renamed import variableFix VTCDuBois fonts not loading in production
In SSR/dynamic rendering mode, the Node.js server handles all requests before Vercel rewrites fire. Since VTCDuBois font files are gitignored and not in the deployment, the server returns 404 before the Blob rewrite can kick in.
Fix service icons showing letter fallbacks instead of real logos
17 static letter-SVG fallbacks in public/icons/ (perplexity, replicate, mapbox, suno, etc.) were blocking the Blob-hosted logo.dev icons from being served. The /api/icon endpoint already generates letter fallbacks as a last resort.
Fix 404 ASCII art compressed vertically on mobile
Verified
pnpm check:typespassespnpm buildpasses