Aggregate internal task queue metrics under __temporal_sys__ tag#9769
Closed
Aggregate internal task queue metrics under __temporal_sys__ tag#9769
Conversation
rkannan82
force-pushed
the
kannan/suppress-internal-tq-metrics
branch
2 times, most recently
from
6498271 to
c43a8c3
Compare
ShahabT
reviewed
Apr 7, 2026
rkannan82
force-pushed
the
kannan/suppress-internal-tq-metrics
branch
from
c43a8c3 to
e26027a
Compare
rkannan82
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… handler Instead of suppressing all metrics for /temporal-sys/ queues with a noop handler, aggregate them under a synthetic "__temporal_sys__" task queue tag. This preserves operational observability while preventing cardinality explosion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
force-pushed
the
kannan/suppress-internal-tq-metrics
branch
from
e2d762d to
f127143
Compare
ShahabT
reviewed
Apr 7, 2026
Addresses review feedback: the prefix check now lives in the metrics package so all callers of GetPerTaskQueue*Scope automatically get the __temporal_sys__ aggregation, not just loggerAndMetricsForPartition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ShahabT
approved these changes
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
force-pushed
the
kannan/suppress-internal-tq-metrics
branch
from
2958e84 to
4353eb9
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
force-pushed
the
kannan/suppress-internal-tq-metrics
branch
from
4353eb9 to
cb8e05b
Compare
ShahabT
approved these changes
Apr 8, 2026
Contributor
Author
|
Closing this PR in favor of introducing a new task queue kind. |
auto-merge was automatically disabled
April 10, 2026 04:43
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
GetPerTaskQueueFamilyScope, task queues with the/temporal-sys/prefix are automatically tagged astaskqueue=__temporal_sys__instead of using the actual queue name, regardless ofBreakdownMetricsByTaskQueuesetting.Why
Internal task queues (e.g.
/temporal-sys/worker-commands/{namespace}/{key}) are per-worker and would cause cardinality explosion. Aggregating under a synthetic label preserves observability while bounding cardinality — same pattern as sticky queues using__sticky__.How did you test it?
Unit test in
matching_engine_test.gothat emits a metric through the per-partition handler and asserts thetaskqueuetag value.