Skip to content

Add chart values priority and priorityClassName for manager #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsulipe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add chart values priority and priorityClassName for manager #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions helm/temporal-worker-controller/templates/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ spec:
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.priorityClassName }}
priorityClassName: {{ . | quote }}
{{- end }}
{{- if and (hasKey .Values "priority") (ne .Values.priority nil) }}
priority: {{ .Values.priority }}
{{- end }}
containers:
- name: manager
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default (printf "v%s" .Chart.AppVersion)}}"
Expand Down
8 changes: 8 additions & 0 deletions helm/temporal-worker-controller/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@
"minimum": 1,
"description": "Termination grace period in seconds"
},
"priority": {
"type": "integer",
"description": "Optional explicit Pod priority integer. Prefer priorityClassName when possible."
},
"priorityClassName": {
"type": "string",
"description": "Optional name of a PriorityClass for the manager Pod"
},
"rbac": {
"type": "object",
"properties": {
Expand Down
6 changes: 6 additions & 0 deletions helm/temporal-worker-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ resources:

terminationGracePeriodSeconds: 10

# Optional Pod priority scheduling. Prefer priorityClassName (references a
# cluster PriorityClass). Set priority only when you need an explicit integer;
# see https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
# priority: 1000
priorityClassName: ""

# All RBAC will be applied under this service account in
# the deployment namespace. You may disable creation of this resource
# if your manager will use a service account that exists at
Expand Down