Skip to content

Bump auto-enroll autoscaling minimum to the fixed poller default #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
veeral-patel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump auto-enroll autoscaling minimum to the fixed poller default #2977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporal-sdk/src/main/java/io/temporal/internal/worker/PollerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static PollerOptions maybeEnrollInPollerAutoscaling(
&& namespaceCapabilities.isPollerAutoscalingAutoEnroll()
&& !(options.getPollerBehavior() instanceof PollerBehaviorAutoscaling)) {
return PollerOptions.newBuilder(options)
.setPollerBehavior(new PollerBehaviorAutoscaling())
.setPollerBehavior(new PollerBehaviorAutoscaling(5, 100, 5))
.build();
}
return options;
Expand Down
4 changes: 2 additions & 2 deletions temporal-sdk/src/test/java/io/temporal/internal/worker/PollerAutoscalingAutoEnrollTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ public void eligibleDefaultIsEnrolledWhenCapabilityAdvertised() {
assertTrue(
"defaulted poller type should switch to autoscaling",
resolved.getPollerBehavior() instanceof PollerBehaviorAutoscaling);
// The enrolled behavior uses the PollerBehaviorAutoscaling defaults.
assertEquals(new PollerBehaviorAutoscaling(), resolved.getPollerBehavior());
// The enrolled behavior uses the explicit auto-enroll min/max/initial values.
assertEquals(new PollerBehaviorAutoscaling(5, 100, 5), resolved.getPollerBehavior());
}

@Test
Expand Down
Loading