Add Kotlin extension for Standalone Activity Client#2923
Open
444am wants to merge 2 commits into
Open
Conversation
444am
commented
Jun 19, 2026
| * | ||
| * @see ActivityClient.newInstance | ||
| */ | ||
| fun ActivityClient( |
Contributor
Author
There was a problem hiding this comment.
As Standalone Activity is yet supported in test-server, this Kotlin extension file is not able to be tested in a way similar to WorkflowClientExt.
I was planning to leverage a temp Activity Client impl like here, but thinking further this means if iface contract changed in the future, the temp client would need to be changed too, which is troublesome.
Eventually I decide to not put UT on this file as of now because Kotlin extension funcs are more about expressiveness than correctness concern. LMK if it's okay for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add Kotlin extension funcs for Standalone Activity Client & its options
Why?
Workflow Client has Kotlin extension funcs in-place, but Standalone Activity Client hasn't got equivalent extensions
How was this tested:
See the new UT file.