Report child workflow termination to the parent in test server#2921
Open
fancyweb wants to merge 1 commit into
Open
Report child workflow termination to the parent in test server#2921fancyweb wants to merge 1 commit into
fancyweb wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
temporal-test-servernow reports child workflow termination to the parent workflow, mirroring how other outcomes (e.g. cancellation) are already handled.Why?
When a child workflow is terminated,
temporal-test-servercloses the child but never notifies the parent. As a result, the parent hangs indefinitely, whereas a real Temporal server rejects it with aChildWorkflowFailure/TerminatedFailure.Checklist
How was this tested:
Rebuilt the
temporal-test-servernative binary and pointed my own previously hanging test at it, and it now completes as expected.Any docs updates needed?
Not that I know of.