remove activity-type targeting from activity pause/unpause/reset/update#978
Open
remove activity-type targeting from activity pause/unpause/reset/update#978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Removed the
activity-typeandmatch-allflags from thetemporal activity {pause,unpause,reset,update-options}commands. This allowed commands to all of the activities of a given type for a single workflow.Why?
These options are confusing for users and in the future the server is planning to support batch operations that will be more intuitive.
Checklist
Closes NA
How was this tested:
Removed tests for this functionality, replaced
TestActivityCommandFailed_BothActivityTpeOrIdwithTestActivityCommandFailed_BothWorkflowIdAndQueryfor workflow-id and query flags. Fixed tests that set the--match-allflags .Any docs updates needed?
NA