💥 Update documention of current_retry_interval and next_attempt_schedule_time#840
Open
dandavison wants to merge 2 commits into
Open
💥 Update documention of current_retry_interval and next_attempt_schedule_time#840dandavison wants to merge 2 commits into
dandavison wants to merge 2 commits into
Conversation
1 task
Quinn-With-Two-Ns
approved these changes
Jul 23, 2026
fretz12
reviewed
Jul 23, 2026
| // failure and when the next attempt will become available to worker poll requests. Set only | ||
| // during retry backoff, i.e. when an activity is currently waiting for a retry, and the next | ||
| // activity task has not yet become available to worker poll requests. Null at all other times, | ||
| // including when paused and during start delay. This is calculated from the active retry policy, |
Contributor
There was a problem hiding this comment.
I believe when paused, the server still returns the stale future next_attempt_schedule_time and current_retry_interval. So I think we should clear those during pause for server
Contributor
Author
There was a problem hiding this comment.
Thanks updated the server PR to do that.
fretz12
approved these changes
Jul 23, 2026
dandavison
force-pushed
the
activity-current-retry-interval
branch
2 times, most recently
from
July 24, 2026 00:29
fd3cd76 to
108be42
Compare
dandavison
force-pushed
the
activity-current-retry-interval
branch
from
July 24, 2026 00:32
108be42 to
26ad7c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
current_retry_intervalfor WFA to reflect breaking behavior change made in Breaking change to current_retry_interval temporal#11203Why?
The current behavior of WFA was deemed to be a bug and changed in temporalio/temporal#11203