Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 77.62% 77.62%
=======================================
Files 9 9
Lines 447 447
Branches 82 82
=======================================
Hits 347 347
Misses 63 63
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@oesteban Sorry, I didn't reload and see your PRs. Would rather not delete a tag just for being premature instead of broken. Will cut a 25.1.1 release when they're in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any objections? In the long run I'd like to deprecate
templateflow.api, but it's nice to have some time between the first release of an alternative approach and the first warnings that the original is going away. Maybe the next release can maketemplateflow.apionly load if accessed.This release already brings
import templateflowdown from 4.7s to 53ms, so I'd like to see how much we can speed up niworkflows and fmriprep loads.