Skip to content

fix(support): shuffle random array values #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
innocenzi merged 1 commit into from
Jun 2, 2026
+10 −1
Merged

fix(support): shuffle random array values #2145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/support/src/Arr/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ function random(iterable $array, int $number = 1, bool $preserveKey = false): mi
}

if ($preserveKey === false) {
shuffle($randomValues);
$randomValues = shuffle($randomValues);
}

return count($randomValues) > 1
Expand Down
9 changes: 9 additions & 0 deletions packages/support/tests/Arr/ManipulatesArrayTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,6 +1142,15 @@ public function test_random(): void
$this->assertCount(3, $randoms);
}

public function test_random_without_preserving_keys_shuffles_selected_values(): void
{
$randoms = arr(range(1, 1_000))->random(100)->toArray();
$ordered = $randoms;
sort($ordered);

$this->assertNotEquals($randoms, $ordered);
}

public function test_random_with_preserve_keys(): void
{
$collection = arr([
Expand Down
Loading