perf(auth): memoize current authenticatable#2144
Open
xHeaven wants to merge 1 commit into
Open
Conversation
xHeaven
force-pushed
the
fix/auth-current-cache
branch
from
afb5438 to
a54d529
Compare
innocenzi
reviewed
Jun 2, 2026
|
|
||
| public const string AUTHENTICATABLE_CLASS = '#authenticatable:class'; | ||
|
|
||
| private bool $currentResolved = false; |
Member
There was a problem hiding this comment.
I think you should be able to get rid of this and only use $current, since when $current is not null, $currentResolved is true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR memoizes the current authenticatable within
SessionAuthenticator. Previously, each call tocurrent()re-resolved the authenticated model from the database, which caused repeated identical queries during authorization checks that rely on the implicit current subject. The authenticator now caches the resolved authenticatable for the current session identity and invalidates that cache when the identity changes, when a new user is authenticated, or when the session is deauthenticated.