fix(core): properly check paths during config loading on Windows#2091
Merged
brendt merged 1 commit intotempestphp:3.xfrom Mar 31, 2026
Merged
fix(core): properly check paths during config loading on Windows#2091brendt merged 1 commit intotempestphp:3.xfrom
brendt merged 1 commit intotempestphp:3.xfrom
Conversation
Benchmark ResultsComparison of Open to see the benchmark resultsNo benchmark changes above ±5%. Generated by phpbench against commit e67d605 |
Contributor
|
Im thinking there should be a test for this so there isnt any regressions again. (I dont use Windows anymore, otherwise id try to help with it 😅) slightly unrelated but the path normalizations should probably be highlighted more in the docs, so people dont use the php constants etc? |
innocenzi
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1535 changed the vendor path check from
/vendor/toDIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATORto fix Windows discovery.Later, PR #1954 added
Path\normalizetoscan(), which converts all paths to forward slashes. This made theDIRECTORY_SEPARATORcheck never match on Windows (it looks for\vendor\in forward-slash paths), so vendor configs get the same priority as user configs and overwrite them viastrcmpordering.Fixes #1982.