fix(database): check explicit relation attributes after singularizing property names#2090
Merged
brendt merged 1 commit intotempestphp:3.xfrom Mar 31, 2026
Merged
Conversation
Benchmark ResultsComparison of Open to see the benchmark resultsNo benchmark changes above ±5%. Generated by phpbench against commit 207fb04 |
laylatichy
force-pushed
the
fix-naming-singularizaton
branch
from
dd5f596 to
7ca5292
Compare
laylatichy
force-pushed
the
fix-naming-singularizaton
branch
from
7ca5292 to
7d45b78
Compare
…g property names getBelongsTo(), getHasOne(), and getHasOneThrough() singularized the property name before checking for explicit relation attributes. This broke any property whose last word is a Latin plural (metadata, data, criteria, media) because singularization produced a non-existent name (e.g. product_metadata → product_metadatum) and the method returned null without ever checking the original property. Now each method checks if the original property has an explicit attribute before recursing with the singularized name.
laylatichy
force-pushed
the
fix-naming-singularizaton
branch
from
7d45b78 to
207fb04
Compare
Member
|
Perfect :) |
regnerisch
pushed a commit
to regnerisch/tempest-framework
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
second half fix for #2086
check if singularized property exists