perf(discovery): support caching discovery in one build pass#2085
Merged
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit de35a86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for caching Discovery with only one
buildpass.It's not a big deal that this is not the case, because we don't care about
discovery:generateperformance, however since it does load the files it go through, some files can be loaded twice during the lifespan of the application, and that may cause issues (such as with files declaring functions without verifying if they exist before).So this work by allowing
(new BootDiscovery)()to return the list of discoveries, and allowing(new GenerateDiscoveryCache)()to receive a list of discoveries, in which case it skips building it again.