feat(discovery): support containers with autowiring#2084
Merged
Conversation
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit ea09f40 |
regnerisch
pushed a commit
to regnerisch/tempest-framework
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates
BootDiscoveryso it doesn't assume every container except Tempest's do not support autowiring.The previous behavior was to check the container instance, verify if it was a Tempest container or if that the container knew about the discovery class. If that was the case, it would resolve the class using the container, and otherwise it would create an instance manually.
However, other containers may support autowiring as well, so instead, I updated the behavior to first try resolving the class from the container, and if it failed with a
Psr\Container\NotFoundExceptionInterface, only then try to create an instance manually. If the class required arguments and could not be instantiated, a nice error is thrown.