fix(view): correctly consume CRLF whitespace in TempestViewLexer #1953
+29
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendt
requested changes
Feb 9, 2026
| return $seek; | ||
| } | ||
|
|
||
| private function isWhitespace(?string $value): bool |
Member
There was a problem hiding this comment.
I understand the use of a function, but this will actually have a pretty significant performance impact. Anything done within the lexer should will be called thousands and thousands of times, and introducing a single function call actually has a measurable performance impact. Since the actual change is minimal, I'll close this PR and add it myself.
Let it be known though that I really appreciate the effort debugging this 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a Windows-only crash.
The lexer advances one character at a time, however the previous check depended on
PHP_EOL. On Windows,PHP_EOLis\r\n(2 characters), which caused inconsistent whitespace checks at CRLF boundaries and crashed during view rendering.