ci: Automate Dependabot configuration generation#9188
ci: Automate Dependabot configuration generation#9188tekton-robot merged 2 commits intotektoncd:mainfrom
Conversation
aa84d12 to
0e0a14c
Compare
afrittoli
left a comment
There was a problem hiding this comment.
Thanks for this. Perhaps for some ecosystems (like GHA), we could setup auto merge if CI passes on release branches, otherwise it will become a lot of work only to approve all the PRs for the various branches 😅
Agreed 👼🏼 But note that we would only update patch dependencies, and it would only do it for the LTSes branches, so it shouldn't be that bad I guess/hope. Also, we could do it today, by applying the labels (lgtm and approved) directly when creating the pull-request 🧌 |
0e0a14c to
934cc29
Compare
|
/retest |
waveywaves
left a comment
There was a problem hiding this comment.
/lgtm
anticipating this to be opened on Monday !
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
934cc29 to
11d6202
Compare
11d6202 to
aa2afc4
Compare
| release-branches: | ||
| - release-v1.9.x | ||
| - release-v1.6.x | ||
| - release-v1.3.x | ||
| - release-v1.0.x |
There was a problem hiding this comment.
This should be be automatically updated I think, it should be coming from a source of truth elsewhere
There was a problem hiding this comment.
Right, for now, the only "source of truth" is the release.md markdown, but not necessarily easy to parse. For now I thought it would make sense to have a post release checklist item for this.. but agreeing that mid/long term it needs to be automated.
There was a problem hiding this comment.
Hmmm, yeah that's not super clean to parse as the source of truth. It could be done using an awk oneliner but it's a little ugly/archaic so not a blocker
E.g. this awk script searches for any 3rd-level heading under ## Release (stops searching at the next 2nd-level heading) which match the regex ### \d+\.\d+, then rewrites the \d\.\d version into the branch name.
$ awk '/^## Release$/{found=1; next} found && /^## /{exit} found && /^### v[0-9]+\.[0-9]+/{sub(/^### /, "release-"); sub(/( \(LTS\))?\s*$/, ".x"); print}' releases.md
release-v1.11.x
release-v1.9.x
release-v1.6.x
release-v1.3.x
release-v1.0.xNote though that regex doesn't check for \(LTS\)$ so it lists release-v1.11.x which is not included in this PR's list.
If we want to leave this list as hardcoded can we update the post-release checklist in this same PR?
aa2afc4 to
8372e7b
Compare
8372e7b to
66588c2
Compare
There was a problem hiding this comment.
zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
- Generate the dependabot configuration to handle LTS branches in order to prevent release branches dependencies drift and reduce manual effort in maintaining per-branch dependency updates - For release branches, only bump dependencies on patch versions - Enable weekly automated checks with PR creation on changes - Generate release-branches list dynamically from releases.md Closes tektoncd#8572 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
66588c2 to
4b9f4dd
Compare
- Add persist-credentials: false to checkout step
- Move all ${{ }} expressions from run: blocks to env: blocks
to prevent template injection vulnerabilities
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
|
/retest |
|
/lgtm |
Changes
order to prevent release branches dependencies drift and reduce manual
effort in maintaining per-branch dependency updates
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/kind misc
/area automation
Closes #8572
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes