fix(release): resolve in-toto attestation UUID in wait-for-chains - #3859
fix(release): resolve in-toto attestation UUID in wait-for-chains#3859infernus01 wants to merge 1 commit into
Conversation
The wait-for-chains task extracts the Rekor UUID from the chains.tekton.dev/transparency annotation, which points at the per-image signature entry (kind hashedrekord). This entry has an empty Attestation field, so the verification commands in the release notes silently produce no output. Search the Rekor index by image digest instead and select the entry whose body kind is intoto — the SLSA attestation that lists published images as subjects. Fall back to the transparency annotation if the attestation entry cannot be found. Ported from tektoncd/pipeline#10363. Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3859 +/- ##
==========================================
+ Coverage 25.41% 25.45% +0.03%
==========================================
Files 450 451 +1
Lines 23607 23665 +58
==========================================
+ Hits 5999 6023 +24
- Misses 16918 16951 +33
- Partials 690 691 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Changes
Summary
wait-for-chainsinline task to resolve the correct RekorUUID (in-toto attestation) instead of the per-image signature
(hashedrekord) entry
Problem
The
chains.tekton.dev/transparencyannotation on the publish-imagesTaskRun points at a
hashedrekordRekor entry. This entry contains abare signature with no
.Attestationpayload, so the release notesverification commands (
rekor-cli get --uuid ... | jq -r .Attestation)return empty. Verified broken on: chains v0.28.1, chains v0.29.0,
pruner v0.4.0, pruner v0.4.1.
Fix
Instead of trusting the transparency annotation, the task now:
IMAGESresult from the publish-images TaskRunimage digest
intotoSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes
/kind bug