Skip to content

chore(deps): consolidate vt10x dependency - #3085

Open
anwesha-palit-redhat wants to merge 1 commit into
tektoncd:mainfrom
anwesha-palit-redhat:cleanup-vt10x
Open

chore(deps): consolidate vt10x dependency#3085
anwesha-palit-redhat wants to merge 1 commit into
tektoncd:mainfrom
anwesha-palit-redhat:cleanup-vt10x

Conversation

@anwesha-palit-redhat

@anwesha-palit-redhat anwesha-palit-redhat commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Removed github.com/ActiveState/vt10x by consolidating all VT10X usage on github.com/hinshun/vt10x, which is already used by the CLI test infrastructure. Updated the remaining test utility to use the shared implementation, eliminating the duplicate terminal emulator dependency.

This change removes a duplicate dependency, reduces the dependency graph, and cleans up vendor files without changing test behavior.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

Removed github.com/ActiveState/vt10x by consolidating all VT10X usage on github.com/hinshun/vt10x, which is already used by the CLI test infrastructure. Updated the remaining test utility to use the shared implementation, eliminating the duplicate terminal emulator dependency.

This change removes a duplicate dependency, reduces the dependency graph, and cleans up vendor files without changing test behavior.

Signed-off-by: Anwesha Palit <apalit@redhat.com>

Assisted-by: Cursor
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vinamra28 after the PR has been reviewed.
You can assign the PR to them by writing /assign @vinamra28 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 3, 2026
@tekton-robot
tekton-robot requested a review from pratap0007 August 3, 2026 09:30
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 3, 2026
@anwesha-palit-redhat

Copy link
Copy Markdown
Contributor Author

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 3, 2026
@divyansh42
divyansh42 requested a review from Copilot August 3, 2026 14:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the dependency graph by removing the vendored github.com/ActiveState/vt10x terminal emulator (and its transitive github.com/kr/pty) and consolidates all VT10X usage onto github.com/hinshun/vt10x, which is already used by the repo’s shared test helpers.

Changes:

  • Removed github.com/ActiveState/vt10x and github.com/kr/pty from go.mod and vendored sources.
  • Updated the remaining prompt test utility to use the shared test/helper.NewVT10XConsole implementation.
  • Refreshed vendor/modules.txt and go.sum to reflect the consolidated dependency set.

Reviewed changes

Copilot reviewed 2 out of 46 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vendor/modules.txt Drops ActiveState/vt10x and kr/pty from the vendored module list.
vendor/github.com/kr/pty/ztypes_s390x.go Removes vendored kr/pty (arch types).
vendor/github.com/kr/pty/ztypes_ppc64le.go Removes vendored kr/pty (arch types).
vendor/github.com/kr/pty/ztypes_ppc64.go Removes vendored kr/pty (arch types).
vendor/github.com/kr/pty/ztypes_openbsd_amd64.go Removes vendored kr/pty (OpenBSD types).
vendor/github.com/kr/pty/ztypes_mipsx.go Removes vendored kr/pty (MIPS/Linux types).
vendor/github.com/kr/pty/ztypes_freebsd_arm.go Removes vendored kr/pty (FreeBSD/ARM types).
vendor/github.com/kr/pty/ztypes_freebsd_amd64.go Removes vendored kr/pty (FreeBSD/AMD64 types).
vendor/github.com/kr/pty/ztypes_freebsd_386.go Removes vendored kr/pty (FreeBSD/386 types).
vendor/github.com/kr/pty/ztypes_dragonfly_amd64.go Removes vendored kr/pty (DragonFly types).
vendor/github.com/kr/pty/ztypes_arm64.go Removes vendored kr/pty (ARM64 types).
vendor/github.com/kr/pty/ztypes_arm.go Removes vendored kr/pty (ARM types).
vendor/github.com/kr/pty/ztypes_amd64.go Removes vendored kr/pty (AMD64 types).
vendor/github.com/kr/pty/ztypes_386.go Removes vendored kr/pty (386 types).
vendor/github.com/kr/pty/util.go Removes vendored kr/pty (terminal size helpers).
vendor/github.com/kr/pty/run.go Removes vendored kr/pty (process start helper).
vendor/github.com/kr/pty/README.md Removes vendored kr/pty documentation.
vendor/github.com/kr/pty/pty_unsupported.go Removes vendored kr/pty (unsupported platform stub).
vendor/github.com/kr/pty/pty_openbsd.go Removes vendored kr/pty (OpenBSD implementation).
vendor/github.com/kr/pty/pty_linux.go Removes vendored kr/pty (Linux implementation).
vendor/github.com/kr/pty/pty_freebsd.go Removes vendored kr/pty (FreeBSD implementation).
vendor/github.com/kr/pty/pty_dragonfly.go Removes vendored kr/pty (DragonFly implementation).
vendor/github.com/kr/pty/pty_darwin.go Removes vendored kr/pty (Darwin implementation).
vendor/github.com/kr/pty/mktypes.bash Removes vendored kr/pty codegen helper.
vendor/github.com/kr/pty/License Removes vendored kr/pty license file.
vendor/github.com/kr/pty/ioctl.go Removes vendored kr/pty ioctl helper.
vendor/github.com/kr/pty/ioctl_bsd.go Removes vendored kr/pty BSD ioctl constants/helpers.
vendor/github.com/kr/pty/doc.go Removes vendored kr/pty package entrypoint.
vendor/github.com/kr/pty/.gitignore Removes vendored kr/pty gitignore.
vendor/github.com/ActiveState/vt10x/vt.go Removes vendored ActiveState/vt10x implementation.
vendor/github.com/ActiveState/vt10x/strip.go Removes vendored ActiveState/vt10x strip helper.
vendor/github.com/ActiveState/vt10x/str.go Removes vendored ActiveState/vt10x STR escape parsing.
vendor/github.com/ActiveState/vt10x/state.go Removes vendored ActiveState/vt10x state machine and helpers.
vendor/github.com/ActiveState/vt10x/README.md Removes vendored ActiveState/vt10x documentation.
vendor/github.com/ActiveState/vt10x/parse.go Removes vendored ActiveState/vt10x parser.
vendor/github.com/ActiveState/vt10x/LICENSE Removes vendored ActiveState/vt10x license file.
vendor/github.com/ActiveState/vt10x/ioctl_posix.go Removes vendored ActiveState/vt10x pty resize (posix).
vendor/github.com/ActiveState/vt10x/ioctl_other.go Removes vendored ActiveState/vt10x pty resize (other).
vendor/github.com/ActiveState/vt10x/expect.go Removes vendored ActiveState/vt10x go-expect console helper.
vendor/github.com/ActiveState/vt10x/doc.go Removes vendored ActiveState/vt10x package doc.
vendor/github.com/ActiveState/vt10x/csi.go Removes vendored ActiveState/vt10x CSI parsing/handling.
vendor/github.com/ActiveState/vt10x/color.go Removes vendored ActiveState/vt10x color definitions.
vendor/github.com/ActiveState/vt10x/.travis.yml Removes vendored ActiveState/vt10x CI config.
pkg/cmd/hub/test/prompt/prompt.go Switches prompt test helper to use shared test/helper.NewVT10XConsole.
go.sum Removes checksums for dropped direct dependency and related transitive entries.
go.mod Removes direct ActiveState/vt10x and indirect kr/pty requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants