chore(deps): consolidate vt10x dependency - #3085
Conversation
Removed github.com/ActiveState/vt10x by consolidating all VT10X usage on github.com/hinshun/vt10x, which is already used by the CLI test infrastructure. Updated the remaining test utility to use the shared implementation, eliminating the duplicate terminal emulator dependency. This change removes a duplicate dependency, reduces the dependency graph, and cleans up vendor files without changing test behavior. Signed-off-by: Anwesha Palit <apalit@redhat.com> Assisted-by: Cursor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/release-note-none |
There was a problem hiding this comment.
Pull request overview
This PR reduces the dependency graph by removing the vendored github.com/ActiveState/vt10x terminal emulator (and its transitive github.com/kr/pty) and consolidates all VT10X usage onto github.com/hinshun/vt10x, which is already used by the repo’s shared test helpers.
Changes:
- Removed
github.com/ActiveState/vt10xandgithub.com/kr/ptyfromgo.modand vendored sources. - Updated the remaining prompt test utility to use the shared
test/helper.NewVT10XConsoleimplementation. - Refreshed
vendor/modules.txtandgo.sumto reflect the consolidated dependency set.
Reviewed changes
Copilot reviewed 2 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/modules.txt | Drops ActiveState/vt10x and kr/pty from the vendored module list. |
| vendor/github.com/kr/pty/ztypes_s390x.go | Removes vendored kr/pty (arch types). |
| vendor/github.com/kr/pty/ztypes_ppc64le.go | Removes vendored kr/pty (arch types). |
| vendor/github.com/kr/pty/ztypes_ppc64.go | Removes vendored kr/pty (arch types). |
| vendor/github.com/kr/pty/ztypes_openbsd_amd64.go | Removes vendored kr/pty (OpenBSD types). |
| vendor/github.com/kr/pty/ztypes_mipsx.go | Removes vendored kr/pty (MIPS/Linux types). |
| vendor/github.com/kr/pty/ztypes_freebsd_arm.go | Removes vendored kr/pty (FreeBSD/ARM types). |
| vendor/github.com/kr/pty/ztypes_freebsd_amd64.go | Removes vendored kr/pty (FreeBSD/AMD64 types). |
| vendor/github.com/kr/pty/ztypes_freebsd_386.go | Removes vendored kr/pty (FreeBSD/386 types). |
| vendor/github.com/kr/pty/ztypes_dragonfly_amd64.go | Removes vendored kr/pty (DragonFly types). |
| vendor/github.com/kr/pty/ztypes_arm64.go | Removes vendored kr/pty (ARM64 types). |
| vendor/github.com/kr/pty/ztypes_arm.go | Removes vendored kr/pty (ARM types). |
| vendor/github.com/kr/pty/ztypes_amd64.go | Removes vendored kr/pty (AMD64 types). |
| vendor/github.com/kr/pty/ztypes_386.go | Removes vendored kr/pty (386 types). |
| vendor/github.com/kr/pty/util.go | Removes vendored kr/pty (terminal size helpers). |
| vendor/github.com/kr/pty/run.go | Removes vendored kr/pty (process start helper). |
| vendor/github.com/kr/pty/README.md | Removes vendored kr/pty documentation. |
| vendor/github.com/kr/pty/pty_unsupported.go | Removes vendored kr/pty (unsupported platform stub). |
| vendor/github.com/kr/pty/pty_openbsd.go | Removes vendored kr/pty (OpenBSD implementation). |
| vendor/github.com/kr/pty/pty_linux.go | Removes vendored kr/pty (Linux implementation). |
| vendor/github.com/kr/pty/pty_freebsd.go | Removes vendored kr/pty (FreeBSD implementation). |
| vendor/github.com/kr/pty/pty_dragonfly.go | Removes vendored kr/pty (DragonFly implementation). |
| vendor/github.com/kr/pty/pty_darwin.go | Removes vendored kr/pty (Darwin implementation). |
| vendor/github.com/kr/pty/mktypes.bash | Removes vendored kr/pty codegen helper. |
| vendor/github.com/kr/pty/License | Removes vendored kr/pty license file. |
| vendor/github.com/kr/pty/ioctl.go | Removes vendored kr/pty ioctl helper. |
| vendor/github.com/kr/pty/ioctl_bsd.go | Removes vendored kr/pty BSD ioctl constants/helpers. |
| vendor/github.com/kr/pty/doc.go | Removes vendored kr/pty package entrypoint. |
| vendor/github.com/kr/pty/.gitignore | Removes vendored kr/pty gitignore. |
| vendor/github.com/ActiveState/vt10x/vt.go | Removes vendored ActiveState/vt10x implementation. |
| vendor/github.com/ActiveState/vt10x/strip.go | Removes vendored ActiveState/vt10x strip helper. |
| vendor/github.com/ActiveState/vt10x/str.go | Removes vendored ActiveState/vt10x STR escape parsing. |
| vendor/github.com/ActiveState/vt10x/state.go | Removes vendored ActiveState/vt10x state machine and helpers. |
| vendor/github.com/ActiveState/vt10x/README.md | Removes vendored ActiveState/vt10x documentation. |
| vendor/github.com/ActiveState/vt10x/parse.go | Removes vendored ActiveState/vt10x parser. |
| vendor/github.com/ActiveState/vt10x/LICENSE | Removes vendored ActiveState/vt10x license file. |
| vendor/github.com/ActiveState/vt10x/ioctl_posix.go | Removes vendored ActiveState/vt10x pty resize (posix). |
| vendor/github.com/ActiveState/vt10x/ioctl_other.go | Removes vendored ActiveState/vt10x pty resize (other). |
| vendor/github.com/ActiveState/vt10x/expect.go | Removes vendored ActiveState/vt10x go-expect console helper. |
| vendor/github.com/ActiveState/vt10x/doc.go | Removes vendored ActiveState/vt10x package doc. |
| vendor/github.com/ActiveState/vt10x/csi.go | Removes vendored ActiveState/vt10x CSI parsing/handling. |
| vendor/github.com/ActiveState/vt10x/color.go | Removes vendored ActiveState/vt10x color definitions. |
| vendor/github.com/ActiveState/vt10x/.travis.yml | Removes vendored ActiveState/vt10x CI config. |
| pkg/cmd/hub/test/prompt/prompt.go | Switches prompt test helper to use shared test/helper.NewVT10XConsole. |
| go.sum | Removes checksums for dropped direct dependency and related transitive entries. |
| go.mod | Removes direct ActiveState/vt10x and indirect kr/pty requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Removed github.com/ActiveState/vt10x by consolidating all VT10X usage on github.com/hinshun/vt10x, which is already used by the CLI test infrastructure. Updated the remaining test utility to use the shared implementation, eliminating the duplicate terminal emulator dependency.
This change removes a duplicate dependency, reduces the dependency graph, and cleans up vendor files without changing test behavior.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes
NONE