Apply plugin envvars to phases not on command line#4472
Open
Conversation
happz
added
code | cli
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
2 tasks
happz
force-pushed
the
apply-plugin-envvars-to-phases-not-on-command-line
branch
2 times, most recently
from
ed55ac9 to
4958b5a
Compare
happz
force-pushed
the
apply-plugin-envvars-to-phases-not-on-command-line
branch
from
4958b5a to
6f0d7cb
Compare
happz
force-pushed
the
apply-plugin-envvars-to-phases-not-on-command-line
branch
from
6f0d7cb to
36ce777
Compare
happz
force-pushed
the
apply-plugin-envvars-to-phases-not-on-command-line
branch
from
36ce777 to
f794152
Compare
This was a major drawback when using envvars to populate or change phases' configuration: plugin-specific envvars had no effect unless the plugin was invoked via command line. This was caused by Click consuming them, and without mentioning the plugin on command line, Click was not invoked, therefore nothing consumed said envvars. The patch adds one more pass into the application of CLI invocations where we collect all these envvars, and then we use Click to process them. The produced values are then added into raw step data. We do not use custom parsers or type casting, we identify the plugin in question from the envvar name, and use its Click command and its parameters to perform the necessary steps for us. This should be equivalent to what Click does when crunching the command line.
happz
force-pushed
the
apply-plugin-envvars-to-phases-not-on-command-line
branch
from
f794152 to
730a38a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin envvars take effect even when plugin is not mentioned on CLI
This was a major drawback when using envvars to populate or change
phases' configuration: plugin-specific envvars had no effect unless the
plugin was invoked via command line. This was caused by Click consuming
them, and without mentioning the plugin on command line, Click was not
invoked, therefore nothing consumed said envvars.
The patch adds one more pass into the application of CLI invocations
where we collect all these envvars, and then we use Click to process
them. The produced values are then added into raw step data.
We do not use custom parsers or type casting, we identify the plugin in
question from the envvar name, and use its Click command and its
parameters to perform the necessary steps for us. This should be
equivalent to what Click does when crunching the command line.
Pull Request Checklist