PHP 8 error handler fix about removed parameter context#208
Open
thomaslauria wants to merge 3 commits intotechnosophos:masterfrom
Open
PHP 8 error handler fix about removed parameter context#208thomaslauria wants to merge 3 commits intotechnosophos:masterfrom
thomaslauria wants to merge 3 commits intotechnosophos:masterfrom
Conversation
Update ParseException.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PHP 8 the 5th parameter context was removed from the errors passed to the error handlers attached with set_error_handler.
Therefore the two eror handler functions creating the io and parse exception are changed to respect that.