chore: remove dead binary-build and unused config files#10417
chore: remove dead binary-build and unused config files#10417davidfirst wants to merge 3 commits into
Conversation
Continues the root cleanup. These are all leftovers from the old bit-bin standalone-binary era or are otherwise unreferenced: - .circleci/config.yml.bak: stale 58KB backup, referenced nowhere - Jenkinsfile: last touched 2017; CI runs entirely on CircleCI - .snyk: 2019 policy file; vulnerability scanning is handled by Dependabot - scripts/linux/ + the build-centos-image/build-debian-image npm scripts: fpm/rpm/deb packaging that consumed the output of the pkg:all script already removed in #10415; not referenced by the active CircleCI config
Code Review by Qodo
1.
|
PR Summary by QodoRemove obsolete CI and Linux packaging artifacts WalkthroughsDescription• Delete unreferenced CI/security config leftovers (.circleci backup, Jenkinsfile, .snyk). • Remove deprecated Linux packaging toolchain under scripts/linux. • Drop unused npm scripts that built legacy CentOS/Debian packaging images. Diagramgraph TD
A["Repo automation"] --> B["CircleCI config"] --> C["package.json scripts"] --> D["scripts/linux packaging"]
A --> E["Jenkinsfile (removed)"]
A --> F[".snyk policy (removed)"]
A --> G["config.yml.bak (removed)"]
High-Level AssessmentThe following are alternative approaches to this PR: 1. Archive legacy assets (e.g., in docs/ or .archive/)
2. Deprecate first, delete later (two-step removal)
Recommendation: Proceed with deletion as implemented since the removed files/scripts are explicitly unreferenced by active CI, and the package.json entries were unused. The only caveat is release automation: consider doing a quick repo-wide search in CI/release docs and GitHub workflows for any remaining references to scripts/linux (or related installer scripts) before merging, but the PR’s approach is the cleanest end state. File ChangesOther (1)
|
Confirmed with the team that BVM does not use any of these. They are all
part of the retired standalone-binary distribution flow (the old bit-bin
download + OS installers), superseded by npm + BVM:
- build-{tar,deb,dist,chocolatey}, build-windows-installer.bat,
copyArtifacts.ps1, deploy-windows.ps1, node-installer.{sh,ps1}
- install.js (old postinstall that downloaded the bit-bin executable) and
its only consumer scripts-constants.js
- set-installation-method.js (only used by the build/installer scripts)
- bootstrap-env-ubuntu.sh (installed fpm/rpm + global bit-bin for packaging)
- scripts/macos/ (Homebrew formula), scripts/windows/ (WiX MSI installer)
None are referenced by the active CircleCI config or GitHub workflows.
Removing build-deb.sh/build-tar.sh here also clears the dangling
scripts/linux reference noted earlier in this PR.
|
Code review by qodo was updated up to the latest commit 104179a |
|
Code review by qodo was updated up to the latest commit eeea332 |
Removes leftovers from the old
bit-binstandalone-binary distribution era and other unreferenced files. Verified none are referenced by the active.circleci/config.ymlor GitHub workflows.Unused config / CI
.circleci/config.yml.bak— stale 58 KB backup ofconfig.ymlJenkinsfile— last touched 2017; CI runs entirely on CircleCI.snyk— 2019 policy file; vulnerability scanning is handled by DependabotDead native-binary / installer flow
Bit ships via npm + BVM now; the team confirmed BVM doesn't use any of these.
scripts/linux/+ thebuild-centos-image/build-debian-imagenpm scripts — fpm/rpm/deb packagingscripts/macos/(Homebrew formula) andscripts/windows/(WiX MSI installer)build-{tar,deb,dist,chocolatey},build-windows-installer.bat,copyArtifacts.ps1,deploy-windows.ps1,node-installer.{sh,ps1}install.js(old postinstall that downloaded thebit-binexecutable) + its only consumerscripts-constants.jsset-installation-method.js(only used by the build/installer scripts) andbootstrap-env-ubuntu.sh(installed fpm + globalbit-bin)Kept:
scripts/docker-teambit-bit/(used by active CI),scripts/package-utils.js(used bycleanup-node-modules.js), and all dev/validate/generate scripts.