Skip to content

(#20) Initial setup of static poses for subsystems#69

Merged
thetaback merged 18 commits intomainfrom
30-setup-3d-sim
Mar 21, 2026
Merged

(#20) Initial setup of static poses for subsystems#69
thetaback merged 18 commits intomainfrom
30-setup-3d-sim

Conversation

@thetaback
Copy link
Copy Markdown
Contributor

  • added 3D CAD model of each component
  • positioned each element such that it matches the static CAD model
  • still needs implementation of movement of climb, the hood, and the shooter rotating

- added 3D CAD model of each component
- positioned each element such that it matches the static CAD model
- still needs implementation of movement of climb, the hood, and the
  shooter rotating
@godmar godmar changed the title (#30) Inital setup of static poses for subsystems (#30) Initial setup of static poses for subsystems Feb 19, 2026
@thetaback thetaback requested a review from godmar February 27, 2026 23:56
@thetaback thetaback changed the title (#30) Initial setup of static poses for subsystems (#20) Initial setup of static poses for subsystems Feb 27, 2026
Copy link
Copy Markdown
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change.

Comment thread src/main/java/frc/robot/RobotContainer.java Outdated
@aidnem aidnem added the sim Sim-only changes label Mar 6, 2026
@aidnem
Copy link
Copy Markdown
Contributor

aidnem commented Mar 20, 2026

@thetaback is this about ready for merge? I'd like to use the 3D model to validate some hood protection changes we're considering for auto.

@thetaback
Copy link
Copy Markdown
Contributor Author

@thetaback is this about ready for merge? I'd like to use the 3D model to validate some hood protection changes we're considering for auto.

I'm planning to get this in by tonight, sorry for the delay. Also, should I come to shop tonight or tomorrow?

@thetaback
Copy link
Copy Markdown
Contributor Author

@aidnem I noticed both in sim and in real life that the turret seems to jolt to a different direction (away from the hub) whenever the robot starts moving. Is this an issue with the scoring on the move logic?

@aidnem
Copy link
Copy Markdown
Contributor

aidnem commented Mar 21, 2026

@thetaback it aims away from the hub because it's leading its shots (for example, if you're moving to the left you have to aim to the right of the hub so that the fuel won't miss left). I don't think it's an "issue" unless we're missing shots. When I tested it at shop a couple weeks ago it seemed to actually make the shots it was shooting while appearing to aim away.

@thetaback thetaback requested a review from aidnem March 21, 2026 01:54
@thetaback
Copy link
Copy Markdown
Contributor Author

@aidnem The turret seems to move so far away from the hub that it's aiming outside of the field. If this is fine in real life, then maybe it's not an issue, but in sim it seems way off (?) Also, what should my next task be? Do I need to go to shop tomorrow to work on anything?

@aidnem
Copy link
Copy Markdown
Contributor

aidnem commented Mar 21, 2026

The turret seems to move so far away from the hub that it's aiming outside of the field.

This is probably not correct. I can test it out, most likely tomorrow morning.

Also, what should my next task be? Do I need to go to shop tomorrow to work on anything?

I'm not sure on your next task. Could you take care of team401/coppercore#257? I don't think you need to come to shop tomorrow, we'll just be testing out new mechanisms as they come and then running autos. I plan to go over system test procedure with you on Monday if possible.

@godmar godmar self-requested a review March 21, 2026 11:57
@godmar
Copy link
Copy Markdown
Contributor

godmar commented Mar 21, 2026

The turret seems to move so far away from the hub that it's aiming outside of the field.

This is probably not correct. I can test it out, most likely tomorrow morning.

Also, what should my next task be? Do I need to go to shop tomorrow to work on anything?

I'm not sure on your next task. Could you take care of team401/coppercore#257? I don't think you need to come to shop tomorrow, we'll just be testing out new mechanisms as they come and then running autos. I plan to go over system test procedure with you on Monday if possible.

I would like @thetaback to help testing the autos in sim.

@godmar
Copy link
Copy Markdown
Contributor

godmar commented Mar 21, 2026

The original issue also asks for a README

@aidnem
Copy link
Copy Markdown
Contributor

aidnem commented Mar 21, 2026

@thetaback sorry for the late notice, but I thought about it some more & discussed with Preston and we think it would be good for you to be at shop today for a couple reasons:

  • Shadowing shooter tuning/auto testing: good opportunity to learn how this will work for next year
  • Tuning shot maps: shot map tuning went way smoother with you there to run the GUI

Hopefully you can still make it.

@thetaback
Copy link
Copy Markdown
Contributor Author

@aidnem I should be able to make it by two. I'll also make sure to bring the camera equipment for shot map tuning.

@aidnem
Copy link
Copy Markdown
Contributor

aidnem commented Mar 21, 2026

Hopefully we won't need to make an entirely new map but it's good to be prepared in case we do.

Copy link
Copy Markdown
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the README describing the steps needed for setting up advantagescope.
Otherwise, if @aidnem agrees it works for his purposes, it's good to go.

@aidnem
Copy link
Copy Markdown
Contributor

aidnem commented Mar 21, 2026

Just tested this out and I'm satisfied. @godmar, do you want me to review the code or are you happy with it?

@godmar
Copy link
Copy Markdown
Contributor

godmar commented Mar 21, 2026

Just tested this out and I'm satisfied. @godmar, do you want me to review the code or are you happy with it?

I'm fine with it once the README is there.

These are basically the same as last year. I did not add any specific
sim instructions for this year's game.
Copy link
Copy Markdown
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 details I think need updating.

Comment thread README.md Outdated
Comment thread README.md
Copy link
Copy Markdown
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thetaback thetaback merged commit bf9a39b into main Mar 21, 2026
3 checks passed
@aidnem aidnem deleted the 30-setup-3d-sim branch March 21, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sim Sim-only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants