Skip to content

Comments

54 add shift detection#58

Merged
aidnem merged 20 commits intomainfrom
54-add-shift-detection
Feb 24, 2026
Merged

54 add shift detection#58
aidnem merged 20 commits intomainfrom
54-add-shift-detection

Conversation

@j0shuaS
Copy link
Contributor

@j0shuaS j0shuaS commented Feb 12, 2026

allows for the ability to track the current shift we are based off of the FMS data with a grace period for delays.

Screen.Recording.2026-02-12.183554.mp4

@j0shuaS j0shuaS requested review from aidnem and godmar February 12, 2026 23:37
@j0shuaS j0shuaS linked an issue Feb 12, 2026 that may be closed by this pull request
Copy link
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. See below.

@godmar
Copy link
Contributor

godmar commented Feb 15, 2026

@j0shuaS please respond to/resolve all conversations here before requesting re-review

@j0shuaS j0shuaS requested review from aidnem and godmar February 21, 2026 20:39
Copy link
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

aidnem
aidnem previously requested changes Feb 22, 2026
@aidnem
Copy link
Contributor

aidnem commented Feb 22, 2026

@j0shuaS do you think we can get this merged today? I've fixed a few of the changes on my local branch but wanted to give you the opportunity to finish this first.

@aidnem aidnem requested a review from godmar February 23, 2026 04:14
Copy link
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the few comments below though.
Particularly about correcting operator error which is not possible (if my reading of the code is right)

@godmar godmar dismissed aidnem’s stale review February 23, 2026 17:44

@aidnem is now developing on this branch

…d; Protect against null game data; log auto winner
@aidnem aidnem requested a review from godmar February 23, 2026 18:10
Copy link
Contributor

@godmar godmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for some cleanup I think.

@aidnem aidnem requested a review from godmar February 23, 2026 23:22
@aidnem aidnem merged commit ae680ed into main Feb 24, 2026
3 checks passed
@aidnem aidnem deleted the 54-add-shift-detection branch February 24, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add shift detection/match strategy to track current match state

3 participants